Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the patch for Spotify API Bug after Spotify fixed the problem. #461

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

ramsayleung
Copy link
Owner

@ramsayleung ramsayleung commented Mar 8, 2024

Description

  1. Revert the patch for Spotify API Bug after Spotify fixed the problem.
  2. Migrate the deprecated APIs in chrono to the recommended ones, otherwise the CI jobs will fail.

Motivation and Context

#452
#457

Dependencies

None

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

All existing tests pass

Is this change properly documented?

It's not necessary.

Don't forget to add an entry to the CHANGELOG if necessary (new features, breaking changes, relevant internal improvements).

@ramsayleung ramsayleung merged commit f0d6a4d into master Mar 8, 2024
6 checks passed
@ramsayleung ramsayleung deleted the ramsay/revert-float-point-patch branch March 8, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant